Bin sh 1 syntax error end of file unexpected expecting fi

• Печать

Тема: Помогите со скриптом  (Прочитано 6397 раз)

• Печать

• 
• Forum
• The Ubuntu Forum Community
• Ubuntu Official Flavours Support
• General Help
• [SOLVED] bash — expecting «fi» but it is already there

1. bash — expecting «fi» but it is already there
   

   I’ve wrote a little bash script to ease the installation of programs which are not part of the standard installation of ubuntu:

   Code:

   #! /bin/bash
   #installing ubuntu-restricted-extras vlc, SUN Java, handbrake, bumblebee (hybrid graphics management tool), skype, pidgin, Thunderbird 
   echo ""
   echo ""
   echo "Willkommen bei der Installationsroutine fuer das Asus X5MSN"
   echo "------------------------------------------------------------"
   echo ""
   if [ "$(whoami)" != "root" ]; 
   then 
       echo "Das Script muss mit root-Rechten ausgefuehrt werden!"
       echo "Nutze: 'sudo ./script.sh'"
       echo ""
   else
   echo "Installation der Ubuntu-Restricted-Extras ..."
   apt-get -y install ubuntu-restricted-extras
   echo "done"
   sleep 5
   echo "Installation des VLC-Players ..."
   echo "--------------------------------"
   apt-get -y install vlc vlc-data  
   echo "done"
   sleep 5
   echo "Hinzufuegen der PPA: Paketquellen fuer SUN JAVA, Handbrake und bumblebee ..."
   echo "---------------------------------------------------------------------------"
   add-apt-repository ppa:ferramroberto/java 
   add-apt-repository ppa:stebbins/handbrake-releases
   add-apt-repository ppa:mj-casalogic/bumblebee
   cp /etc/apt/sources.list /etc/apt/sources.list.bak 
   sh -c 'echo "deb http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   sh -c 'echo "deb-src http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   apt-get update
   echo "done"
   sleep 5
   echo "Installation von SUN JAVA Runetime Enviroment..."
   echo "------------------------------------------------"
   apt-get -y install sun-java6-jre sun-java6-plugin sun-java6-fonts
   echo "done"
   sleep 5
   echo "Sun Java als Standard-JAVA festlegen"
   echo "------------------------------------"
   update-alternatives --config java
   sleep 5
   echo "Installation von Handbrake ..."
   echo "------------------------------"
   apt-get -y install handbrake
   echo "done"
   sleep 5
   echo "Installation und Konfiguration von bumblebee (fuer Hybrid Graphics INTEL/nVidia) ..."
   echo "-----------------------------------------------------------------------------------"
   apt-get -y install bumblebee
   echo "done"
   sleep 5
   echo "Installation von Thunderbird mit de-language-pack"
   echo "-------------------------------------------------"
   apt-get -y install thunderbird thunderbird-locale-de
   echo "done"
   sleep 5
   echo "Installation von Skype (Colsed Source) ..."
   echo "------------------------------------------"
   apt-get -y install skype
   echo "done"
   sleep 5
   echo "Installation von Pidgin ..."
   echo "---------------------------"
   apt-get -y install pidgin
   echo "done"
   fi 
   exit 0

   The problem is that I get this message:

   (line where you can find «fi»): Syntax error: end of file unexpected (expecting «fi»).

   Where’s the mistake?

   ---

2. Re: bash — expecting «fi» but it is already there
   

   I’m not sure but I dont like the semicolon at the end of the if statement (after the square brackets). Try removing that and see what happens.

   Failing that comment out all the lins in the else clause and uncomment them one by one. But I think it’s something to do with the semicolon.

   Andrew

   ---

3. Re: bash — expecting «fi» but it is already there
   

   Originally Posted by apmcd47
   

   I’m not sure but I dont like the semicolon at the end of the if statement (after the square brackets). Try removing that and see what happens.

   Failing that comment out all the lins in the else clause and uncomment them one by one. But I think it’s something to do with the semicolon.

   Andrew

   By comparing the script to one of my own, i would also try to remove the semi-colon.

   ---

4. Re: bash — expecting «fi» but it is already there
   

   I removed the semicolon but nothing chnaged. If I replace all the code between else and fi by the simple line echo «You are root!» the if condition works fine.

   ---

5. Re: bash — expecting «fi» but it is already there
   

   Try adding a semicolon after each command between else and fi.

   ---

6. Re: bash — expecting «fi» but it is already there
   

   No effect, same error report like without the semicolon after each command

   ---

7. Re: bash — expecting «fi» but it is already there
   

   Try using a function. All those sleep calls might cause issues, or if one of the apt-get requests fails, the if will fail:

   Change:

   Code:

   if [ "$(whoami)" != "root" ]; 
   then 
       echo "Das Script muss mit root-Rechten ausgefuehrt werden!"
       echo "Nutze: 'sudo ./script.sh'"
       echo ""
   else
   echo "Installation der Ubuntu-Restricted-Extras ..."
   apt-get -y install ubuntu-restricted-extras
   echo "done"
   sleep 5
   echo "Installation des VLC-Players ..."
   echo "--------------------------------"
   apt-get -y install vlc vlc-data  
   echo "done"
   sleep 5
   echo "Hinzufuegen der PPA: Paketquellen fuer SUN JAVA, Handbrake und bumblebee ..."
   echo "---------------------------------------------------------------------------"
   add-apt-repository ppa:ferramroberto/java 
   add-apt-repository ppa:stebbins/handbrake-releases
   add-apt-repository ppa:mj-casalogic/bumblebee
   cp /etc/apt/sources.list /etc/apt/sources.list.bak 
   sh -c 'echo "deb http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   sh -c 'echo "deb-src http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   apt-get update
   echo "done"
   sleep 5
   echo "Installation von SUN JAVA Runetime Enviroment..."
   echo "------------------------------------------------"
   apt-get -y install sun-java6-jre sun-java6-plugin sun-java6-fonts
   echo "done"
   sleep 5
   echo "Sun Java als Standard-JAVA festlegen"
   echo "------------------------------------"
   update-alternatives --config java
   sleep 5
   echo "Installation von Handbrake ..."
   echo "------------------------------"
   apt-get -y install handbrake
   echo "done"
   sleep 5
   echo "Installation und Konfiguration von bumblebee (fuer Hybrid Graphics INTEL/nVidia) ..."
   echo "-----------------------------------------------------------------------------------"
   apt-get -y install bumblebee
   echo "done"
   sleep 5
   echo "Installation von Thunderbird mit de-language-pack"
   echo "-------------------------------------------------"
   apt-get -y install thunderbird thunderbird-locale-de
   echo "done"
   sleep 5
   echo "Installation von Skype (Colsed Source) ..."
   echo "------------------------------------------"
   apt-get -y install skype
   echo "done"
   sleep 5
   echo "Installation von Pidgin ..."
   echo "---------------------------"
   apt-get -y install pidgin
   echo "done"
   fi 
   exit 0

   TO:

   Code:

   function install_procedure(){
   
   echo "Installation der Ubuntu-Restricted-Extras ..."
   apt-get -y install ubuntu-restricted-extras
   echo "done"
   sleep 5
   echo "Installation des VLC-Players ..."
   echo "--------------------------------"
   apt-get -y install vlc vlc-data  
   echo "done"
   sleep 5
   echo "Hinzufuegen der PPA: Paketquellen fuer SUN JAVA, Handbrake und bumblebee ..."
   echo "---------------------------------------------------------------------------"
   add-apt-repository ppa:ferramroberto/java 
   add-apt-repository ppa:stebbins/handbrake-releases
   add-apt-repository ppa:mj-casalogic/bumblebee
   cp /etc/apt/sources.list /etc/apt/sources.list.bak 
   sh -c 'echo "deb http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   sh -c 'echo "deb-src http://archive.canonical.com/ubuntu natty partner" >> /etc/apt/sources.list' 
   apt-get update
   echo "done"
   sleep 5
   echo "Installation von SUN JAVA Runetime Enviroment..."
   echo "------------------------------------------------"
   apt-get -y install sun-java6-jre sun-java6-plugin sun-java6-fonts
   echo "done"
   sleep 5
   echo "Sun Java als Standard-JAVA festlegen"
   echo "------------------------------------"
   update-alternatives --config java
   sleep 5
   echo "Installation von Handbrake ..."
   echo "------------------------------"
   apt-get -y install handbrake
   echo "done"
   sleep 5
   echo "Installation und Konfiguration von bumblebee (fuer Hybrid Graphics INTEL/nVidia) ..."
   echo "-----------------------------------------------------------------------------------"
   apt-get -y install bumblebee
   echo "done"
   sleep 5
   echo "Installation von Thunderbird mit de-language-pack"
   echo "-------------------------------------------------"
   apt-get -y install thunderbird thunderbird-locale-de
   echo "done"
   sleep 5
   echo "Installation von Skype (Colsed Source) ..."
   echo "------------------------------------------"
   apt-get -y install skype
   echo "done"
   sleep 5
   echo "Installation von Pidgin ..."
   echo "---------------------------"
   apt-get -y install pidgin
   echo "done"
   }
   
   
   if [ "$(whoami)" != "root" ] 
   then 
       echo "Das Script muss mit root-Rechten ausgefuehrt werden!"
       echo "Nutze: 'sudo ./script.sh'"
       echo ""
   else
   install_procedure
   fi 
   exit 0

   Oh yea, another thing. May be trivial, but its a rule: BASH FILES MUST HAVE ATLEAST A SINGLE EMPTY LINE FOLLOWING THE LAST LINE OF CODE. You have no idea how many times this screwed me over before I started using geany for coding scripts…

   Last edited by zero2xiii; September 4th, 2011 at 12:14 PM.

   Reason: just tought of another thing

   ---

8. Re: bash — expecting «fi» but it is already there
   

   try chancingwithalso make sure the 1st line is #!/bin/bash not #! /bin/bash

   edit: never mind i niticed you have already an «else» statement.

   bash -v (what version r u using?)
   try to run the comman in dash (#!/bin/dash)

   Last edited by fdrake; September 4th, 2011 at 12:34 PM.

   blog
   Donations BTC : 12FwoB7uAM5FnweykpR1AEEDVFaTLTYFkS
   DOUBLEPLUSGOOD!!

   ---

9. Re: bash — expecting «fi» but it is already there
   

   @ zero2xiii

   install_routine_asus.sh: 1: Syntax error: «(» unexpected

   @ fdrake
   install_routine_asus.sh: 14 (else-line): Syntax error: «;» unexpected

   ---

10. Re: bash — expecting «fi» but it is already there
    

    Please upload the file so we can view the EXACT line syntax and compare that to the results you are having.

    The unexpected ( in line 1, is completely wrong. I guess you didn’t read through what I wrote. That is NOT the complete file, only the part you need to change.

    ---

$ sh test.sh
test.sh: 5: test.sh: Syntax error: "(" unexpected (expecting "fi")


#!/bin/bash

if [ 1 -eq 1 ]
    then
    declare -a methods=(Method1 Method2 Method3)
    for i in "${methods[@]}"
       do
          echo $i
      done
    else
      echo not found
fi

1

Related posts:

4 ответы

Не тот ответ, который вы ищете? Просмотрите другие вопросы с метками

bash
makefile

or задайте свой вопрос.

Обратите внимание на GNUmakefile:1:

1 — это номер строки, в которой произошла ошибка

Возможно где-то вместо табуляции затесался пробел. Напоминаю, что в makefile отступы должны быть заданы табуляциями.

Либо таргет перечислен без двоеточия .PHONY clean вместо .PHONY: clean

Либо какая-то похожая ошибка.

Обратите внимание на расстановку ; в конце выражений и расстановку при переносе строк.

Изучите этот

пример

и сравните со своим кодом.

Означает, что make не установлен.

Установить make в rpm системах можно с помощью yum в deb система — с помощью apt