Delete scalar ошибка c

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23

	Menu::~Menu() {
		//Deallocate title
		if (m_title) {
			delete[] m_title;
		}
		m_title = nullptr;

		//Deallocate menu items
		if (m_menuCount > 0) {
			for (int i = 0; i < m_menuCount; i++) {
				delete m_menuItem[i];
				m_menuItem[i] = nullptr;
			}
		}


		//Reset values
		m_menuCount = 0;
		m_indentation = 0;

		m_safe = true;

	}

1
2
3
4
5

   Menu mainMenu("** Main Menu **");
   Menu subMenu1("** Sub Menu One **", 1);
   Menu subMenu2("** Sub Menu **", 2);
   Menu tempMenu("** Temp **");
   Menu invMenu("** To test Invalid Menu **");

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31

-		invMenu	{m_title=0x00925288 "" m_menuItem=0x0073fd20 {0x00000000 <NULL>, 0x00000000 <NULL>, 0x00000000 <NULL>, ...} ...}	sdds::Menu
+		m_title	0x00925288 ""	char *
+		m_menuItem	0x0073fd20 {0x00000000 <NULL>, 0x00000000 <NULL>, 0x00000000 <NULL>, 0x00000000 <NULL>, 0x00000000 <NULL>, ...}	sdds::MenuItem *[11]
		m_menuCount	0	int
		m_indentation	0	int
		m_safe	true	bool
-		mainMenu	{m_title=0x00929b80 "" m_menuItem=0x0073fe30 {0x00931cd0 {m_item=0xdddddddd <Error reading characters of string.> }, ...} ...}	sdds::Menu
+		m_title	0x00929b80 ""	char *
+		m_menuItem	0x0073fe30 {0x00931cd0 {m_item=0xdddddddd <Error reading characters of string.> }, 0x00931f40 {m_item=...}, ...}	sdds::MenuItem *[11]
		m_menuCount	0	int
		m_indentation	0	int
		m_safe	true	bool
-		subMenu1	{m_title=0x00931f70 "" m_menuItem=0x0073fdec {0x00931df0 {m_item=0xdddddddd <Error reading characters of string.> }, ...} ...}	sdds::Menu
+		m_title	0x00931f70 ""	char *
+		m_menuItem	0x0073fdec {0x00931df0 {m_item=0xdddddddd <Error reading characters of string.> }, 0x00931e80 {m_item=...}, ...}	sdds::MenuItem *[11]
		m_menuCount	0	int
		m_indentation	0	int
		m_safe	true	bool
-		subMenu2	{m_title=0x00925248 "** Sub Menu **" m_menuItem=0x0073fda8 {0x00931d90 {m_item=0x0092e1d0 "The first" }, ...} ...}	sdds::Menu
+		m_title	0x00925248 "** Sub Menu **"	char *
+		m_menuItem	0x0073fda8 {0x00931d90 {m_item=0x0092e1d0 "The first" }, 0x00931fd0 {m_item=0x0092e320 "The second" }, ...}	sdds::MenuItem *[11]
		m_menuCount	3	int
		m_indentation	2	int
		m_safe	false	bool
-		tempMenu	{m_title=0x00933278 "** Sub Menu **" m_menuItem=0x0073fd64 {0x00931c40 {m_item=0x0092e208 "The first" }, ...} ...}	sdds::Menu
+		m_title	0x00933278 "** Sub Menu **"	char *
+		m_menuItem	0x0073fd64 {0x00931c40 {m_item=0x0092e208 "The first" }, 0x00931dc0 {m_item=0x0092e2b0 "The second" }, ...}	sdds::MenuItem *[11]
		m_menuCount	3	int
		m_indentation	2	int
		m_safe	false	bool

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50

#define _CRT_SECURE_NO_WARNINGS

#include <cstring>
#include <iostream>

class tempMenu {
private:
	char* m_title;
public:
	tempMenu(const char* title) {
		//Check title, allocate size for array, copy into array
		if (title && title[0] != '') {
			m_title = new char[strlen(title) + 1];
			strcpy(m_title, title);
		}
		else {	//else set to nullptr
			m_title = nullptr;
		}
	}

	~tempMenu() {
		//Deallocate, this is where it breaks
		delete[] m_title;
	}

	void display() {
		std::cout << m_title << std::endl;
	}
};


//Display menu
void testMenu(tempMenu temp) {
	temp.display();
}

int main(){
	
	//Create object
	tempMenu obj("Object");

	//Gets passed into new scope
	testMenu(obj);

	//Returns from scope after going throught destructor, object is essentialy destroyed here

	return 0;	//calls obj destructor, triggers error at delete [] m_title in destructor

}

   testMenus(mainMenu, subMenu1, subMenu2);

   void testMenus(Menu m, Menu sub1, const Menu& sub2)

1
2
3
4
5
6
7
8
9
10

-		mainMenu	{m_title=0x01591068 "** Main Menu **" m_menuItem=0x012ff794 {0x015924e8 {m_item=0x0158e0f0 "Option one" }, ...} ...}	sdds::Menu
-		m_title	0x01591068 "** Main Menu **"	char *
			42 '*'	char
-		subMenu1	{m_title=0x01590ca8 "** Sub Menu One **" m_menuItem=0x012ff750 {0x01592488 {m_item=0x01590f28 "Selection one" }, ...} ...}	sdds::Menu
-		m_title	0x01590ca8 "** Sub Menu One **"	char *
			42 '*'	char
-		subMenu2	{m_title=0x01590ea8 "** Sub Menu **" m_menuItem=0x012ff70c {0x01592638 {m_item=0x0158e1d0 "The first" }, ...} ...}	sdds::Menu
-		m_title	0x01590ea8 "** Sub Menu **"	char *
			42 '*'	char

1
2
3
4
5
6
7

-		mainMenu	{m_title=0x01591068 "ÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝ" m_menuItem=0x012ff794 {0x015924e8 {m_item=0xdddddddd <Error reading characters of string.> }, ...} ...}	sdds::Menu
+		m_title	0x01591068 "ÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝ"	char *
-		subMenu1	{m_title=0x01590ca8 "ÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝ" m_menuItem=0x012ff750 {0x01592488 {m_item=0xdddddddd <Error reading characters of string.> }, ...} ...}	sdds::Menu
+		m_title	0x01590ca8 "ÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝÝ"	char *
-		subMenu2	{m_title=0x01590ea8 "** Sub Menu **" m_menuItem=0x012ff70c {0x01592638 {m_item=0x0158e1d0 "The first" }, ...} ...}	sdds::Menu
+		m_title	0x01590ea8 "** Sub Menu **"	char *

1
2
3
4
5
6
7
8
9
10
11

struct a
{ 
  int* ptr_ = nullptr;
  ~a() { delete ptr_; }
};

int main()
{
  a x { new int };
  a y = x;
}

1
2
3
4
5
6
7
8
9
10
11
12

class tempMenu 
{
public:
  // disallow initialization of one tempMenu from another
  tempMenu(tempMenu const&) = delete; 
  // disallow initialization of one tempMenu from a "temporary" tempMenu
  tempMenu(tempMenu &&) = delete;
  // disallow assignment of this tempMenu from another
  tempMenu& operator=(tempMenu const&) = delete;
  // disallow assignment of this tempMenu from a "temporary" tempMenu
  tempMenu& operator=(tempMenu &&) = delete;
};

1
2
3
4

void testMenu(tempMenu /*const*/& temp) 
{
	temp.display();
}

Menu& operator=(const Menu& menu);

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17

tempMenu(tempMenu const& other)
  : m_title(new char[strlen(other.m_title) + 1]) 
{
  strcpy(m_title, other.m_title);    
}

tempMenu& operator=(tempMenu rhs) 
{
  swap(rhs);
  return *this;
}

void swap(tempMenu& that) noexcept
{
  using std::swap;
  swap(this->m_title, that.m_title);
}