Error assert was not declared in this scope

3

Description

Jack Howarth

2010-09-11 01:28:07 UTC

The new g++.dg/torture/pr44972.C fails to compile at all optimization levels on x86_64-apple-darwin10...

FAIL: g++.dg/torture/pr44972.C  -O0  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O1  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O2  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O3 -fomit-frame-pointer  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O3 -g  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -Os  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O2 -flto  (test for excess errors)
FAIL: g++.dg/torture/pr44972.C  -O2 -fwhopr  (test for excess errors)

The failures are of the form...


/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/g++/../../g++ -B/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/g++/../../ /sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/gcc/testsuite/g++.dg/torture/pr44972.C -nostdinc++ -I/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/x86_64-apple-darwin10.5.0/i386/libstdc++-v3/include/x86_64-apple-darwin10.5.0 -I/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/x86_64-apple-darwin10.5.0/i386/libstdc++-v3/include -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/testsuite/util -fmessage-length=0 -O0 -S -m32 -o pr44972.s
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/gcc/testsuite/g++.dg/torture/pr44972.C: In member function ‘const T* boost::optional<T>::operator->() const [with T = std::pair<NT, NT>]’:
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/gcc/testsuite/g++.dg/torture/pr44972.C:137:9:   instantiated from here
/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/gcc/testsuite/g++.dg/torture/pr44972.C:77:35: error: ‘__assert_fail’ was not declared in this scope

Using built-in specs.
COLLECT_GCC=g++-4
COLLECT_LTO_WRAPPER=/sw/lib/gcc4.6/libexec/gcc/x86_64-apple-darwin10.5.0/4.6.0/lto-wrapper
Target: x86_64-apple-darwin10.5.0
Configured with: ../gcc-4.6-20100910/configure --prefix=/sw --prefix=/sw/lib/gcc4.6 --mandir=/sw/share/man --infodir=/sw/lib/gcc4.6/info --enable-languages=c,c++,fortran,objc,obj-c++,java --with-gmp=/sw --with-libiconv-prefix=/sw --with-ppl=/sw --with-cloog=/sw --with-mpc=/sw --with-system-zlib --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib --program-suffix=-fsf-4.6 --enable-checking=yes
Thread model: posix
gcc version 4.6.0 20100910 (experimental) (GCC)

Comment 1

Jack Howarth

2010-09-11 01:29:47 UTC

Created attachment 21770 [details]
preprocessed source for g++.dg/torture/pr44972.C  -O0

Generated with...

/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/g++/../../g++ -B/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/gcc/testsuite/g++/../../ /sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/gcc/testsuite/g++.dg/torture/pr44972.C -nostdinc++ -I/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/x86_64-apple-darwin10.5.0/i386/libstdc++-v3/include/x86_64-apple-darwin10.5.0 -I/sw/src/fink.build/gcc46-4.6.0-1000/darwin_objdir/x86_64-apple-darwin10.5.0/i386/libstdc++-v3/include -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc46-4.6.0-1000/gcc-4.6-20100910/libstdc++-v3/testsuite/util -fmessage-length=0 -O0 -S -m32 --save-temps -o pr44972.s

on x86_64-apple-darwin10.

Comment 2

Rainer Orth

2010-09-13 16:43:59 UTC

Same on *-*-solaris2* (probably on all non-Linux targets).

Comment 3

Jonathan Wakely

2010-09-13 17:04:52 UTC

the test already includes <cassert> so presumably the fix is simply to replace line 77 with 

 T const* operator->() const { assert(this->is_initialized()) ; return this->get_ptr_impl() ; }

Comment 4

Paolo Carlini

2010-09-13 17:12:25 UTC

I agree with Jon: the expansion of assert to __assert_fail, etc, isn't portable, the testcase should simply use assert.

Comment 5

Jack Howarth

2010-09-13 19:13:16 UTC

I can confirm that the change...

Index: gcc/testsuite/g++.dg/torture/pr44972.C
===================================================================
--- gcc/testsuite/g++.dg/torture/pr44972.C	(revision 164251)
+++ gcc/testsuite/g++.dg/torture/pr44972.C	(working copy)
@@ -74,7 +74,7 @@
 
     T const& get() const ;
 
-    T const* operator->() const { ((this->is_initialized()) ? static_cast<void> (0) : __assert_fail ("this->is_initialized()", "pr44972.C", 78, __PRETTY_FUNCTION__)) ; return this->get_ptr_impl() ; }
+    T const* operator->() const { assert(this->is_initialized()) ; return this->get_ptr_impl() ; }
 
 } ;
 

...eliminates the g++.dg/torture/pr44972.C -O0 failures on x86_64-apple-darwin10 at both -m32 and -m64.

Comment 6

Paolo Carlini

2010-09-13 21:01:48 UTC

Please properly post the patch to the mailing list and let's resolve this rather straightforward issue. Thanks.

Comment 8

Martin Jambor

2010-09-14 11:53:08 UTC

Sorry, I messed up when I tried to remove includes from the testcase.  Thanks for fixing it.

Code:

In file included from ../core/sourcehook/sourcehook.h:118:0,
                 from ../core/ISmmPlugin.h:37,
                 from stub_mm.h:18,
                 from stub_mm.cpp:16:
../core/sourcehook/FastDelegate.h:181:2: error: identifier �static_assert� is a keyword in C++11 [-Werror=c++0x-compat]
  static_assert(sizeof(InputClass)==sizeof(u) && sizeof(InputClass)==sizeof(Outp
  ^
In file included from ../core/sourcehook/sourcehook.h:118:0,
                 from ../core/ISmmPlugin.h:37,
                 from stub_mm.h:18,
                 from stub_mm.cpp:16:
../core/sourcehook/FastDelegate.h: In function �OutputClass fastdelegate::detail::horrible_cast(InputClass)�:
../core/sourcehook/FastDelegate.h:182:29: error: there are no arguments to �static_assert� that depend on a template parameter, so a declaration of �static_assert� must be available [-fpermissive]
    "Can't use horrible cast");
                             ^
../core/sourcehook/FastDelegate.h:182:29: note: (if you use �-fpermissive�, G++ will accept your code, but allowing the use of an undeclared name is deprecated)
../core/sourcehook/FastDelegate.h: In static member function �static fastdelegate::detail::GenericClass* fastdelegate::detail::SimplifyMemFunc<N>::Convert(X*, XFuncType, GenericMemFuncType&)�:
../core/sourcehook/FastDelegate.h:297:82: error: there are no arguments to �static_assert� that depend on a template parameter, so a declaration of �static_assert� must be available [-fpermissive]
 atic_assert(N >= 100, "Unsupported memeber function pointer on this compiler")

Code:

../core/sourcehook/FastDelegate.h:799:16: error: �static_assert� was not declared in this scope
   static_assert(sizeof(UnvoidStaticFuncPtr)==sizeof(this), "Can't use evil meth