Error strings must use singlequote quotes

🔧 Fixable

Some problems reported by this rule are automatically fixable by the --fix command line option

/*eslint quotes: ["error", "double"]*/

var single = 'single';
var unescaped = 'a string containing "double" quotes';
var backtick = `backntick`; // you can use n in single or double quoted strings

/*eslint quotes: ["error", "double"]*/
/*eslint-env es6*/

var double = "double";
var backtick = `back
tick`;  // backticks are allowed due to newline
var backtick = tag`backtick`; // backticks are allowed due to tag

/*eslint quotes: ["error", "single"]*/

var double = "double";
var unescaped = "a string containing 'single' quotes";

/*eslint quotes: ["error", "single"]*/
/*eslint-env es6*/

var single = 'single';
var backtick = `back${x}tick`; // backticks are allowed due to substitution

/*eslint quotes: ["error", "backtick"]*/

var single = 'single';
var double = "double";
var unescaped = 'a string containing `backticks`';

/*eslint quotes: ["error", "backtick"]*/
/*eslint-env es6*/

var backtick = `backtick`;

/*eslint quotes: ["error", "double", { "avoidEscape": true }]*/

var single = 'a string containing "double" quotes';

/*eslint quotes: ["error", "single", { "avoidEscape": true }]*/

var double = "a string containing 'single' quotes";

/*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/

var double = "a string containing `backtick` quotes"

/*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/

var double = "double";
var double = `double`;

/*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/

var single = 'single';
var single = `single`;

Войдите на сайт

Чтобы задать вопрос и получить на него квалифицированный ответ.

Войти через центр авторизации

Ekaterina Lopatina

Коллеги, день добрый. Код правильный, тест проходит. Но выводит другие ошибки.

// removed

Вот такие ошибки выводит

 status: finished → Check your code. Linter failed.

 /usr/src/app/babel.config.js
   3:6  error  Strings must use singlequote                               quotes
   9:2  error  Missing semicolon                                          semi
  10:1  error  Too many blank lines at the end of file. Max of 0 allowed  no-multiple-empty-lines

В чем проблем, помогите разобраться, пожалуйста

0

0

0

1

Problem/Motivation

Currently, we are using a mixture of single quotes and double quotes in our JavaScript, and I can’t see why. When I turn on eslint’s quotes rule set to single quotes, it only returns 215 errors; pretty small compared to turning on the eslint rule and setting it to double quotes: 4013 errors.

Our PHP standards for quotes are pretty clear: https://www.drupal.org/coding-standards#quotes

single quote strings should be used by default. Their use is recommended except in two cases:

1. Deliberate in-line variable interpolation, e.g. «<h2>$header</h2>».
2. Translated strings where one can avoid escaping single quotes by enclosing the string in double quotes. One such string would be «He’s a good person.» It would be ‘He’s a good person.’ with single quotes. Such escaping may not be handled properly by .pot file generators for text translation, and it’s also somewhat awkward to read.

In JavaScript, there is no such thing as #1. But we do have Drupal.t() which can have strings with apostrophes.

So I think we should adopt the same rules for quotes in JavaScript as we already have for PHP.

Fortunately, eslint has a rule that will allow us to: always use single quotes, except when we use double quotes to avoid escaping a single quote or apostrophe in the string.

Proposed resolution

Let’s update our .eslintrc file to add:

"quotes": [2, "single", "avoid-escape"]

Remaining tasks

1. Add the new eslint rule.
2. Fix the 211 linting errors by switching string from double quotes to single quotes.
3. Update Drupal’s JavaScript docs to mention the new recommendation. https://www.drupal.org/node/172169
   

   Quotes

   Single quote strings should be used by default. Their use is recommended except in the following case:

   Translated strings where one can avoid escaping single quotes by enclosing the string in double quotes. One such string would be Drupal.t("She's a good person.") It would be Drupal.t('She's a good person.') with single quotes. Such escaping may not be handled properly by .pot file generators for text translation, and it’s also somewhat awkward to read.

$ npm -g list  | grep eslint

├─┬ eslint@7.4.0

│ ├─┬ eslint-scope@5.1.0

│ ├─┬ eslint-utils@2.1.0

│ │ └── eslint-visitor-keys@1.3.0 deduped

│ ├── eslint-visitor-keys@1.3.0

│ │ └── eslint-visitor-keys@1.3.0 deduped

$ eslint —help

eslint [options] file.js [file.js] [dir]

Basic configuration:

  —no-eslintrc                   Disable use of configuration from .eslintrc.*

  -c, —config path::String       Use this configuration, overriding .eslintrc.* config options if present

  —env [String]                  Specify environments

  —ext [String]                  Specify JavaScript file extensions

  —global [String]               Define global variables

  —parser String                 Specify the parser to be used

  —parser-options Object         Specify parser options

  —resolve-plugins-relative-to path::String  A folder where plugins should be resolved from, CWD by default

Specifying rules and plugins:

  —rulesdir [path::String]       Use additional rules from this directory

  —plugin [String]               Specify plugins

  —rule Object                   Specify rules

Fixing problems:

  —fix                           Automatically fix problems

  —fix-dry-run                   Automatically fix problems without saving the changes to the file system

  —fix-type Array                Specify the types of fixes to apply (problem, suggestion, layout)

Ignoring files:

  —ignore-path path::String      Specify path of ignore file

  —no-ignore                     Disable use of ignore files and patterns

  —ignore-pattern [String]       Pattern of files to ignore (in addition to those in .eslintignore)

Using stdin:

  —stdin                         Lint code provided on <STDIN> — default: false

  —stdin-filename String         Specify filename to process STDIN as

Handling warnings:

  —quiet                         Report errors only — default: false

  —max-warnings Int              Number of warnings to trigger nonzero exit code — default: -1

Output:

  -o, —output-file path::String  Specify file to write report to

  -f, —format String             Use a specific output format — default: stylish

  —color, —no-color             Force enabling/disabling of color

Inline configuration comments:

  —no-inline-config              Prevent comments from changing config or rules

  —report-unused-disable-directives  Adds reported errors for unused eslint-disable directives

Caching:

  —cache                         Only check changed files — default: false

  —cache-file path::String       Path to the cache file. Deprecated: use —cache-location — default: .eslintcache

  —cache-location path::String   Path to the cache file or directory

Miscellaneous:

  —init                          Run config initialization wizard — default: false

  —env-info                      Output execution environment information — default: false

  —no-error-on-unmatched-pattern  Prevent errors when pattern is unmatched

  —debug                         Output debugging information

  -h, —help                      Show help

  -v, —version                   Output the version number

  —print-config path::String     Print the configuration for the given file

{

    «env»: {

        «browser»: true,

        «es2020»: true

    },

    «extends»: «eslint:recommended»,

    «parserOptions»: {

        «ecmaVersion»: 11

    },

    «rules»: {

        «indent»: [

            «error»,

            4

        ],

        «quotes»: [

            «error»,

            «single»

        ],

        «semi»: [

            «error»,

            «always»

        ]

    }

}

  «devDependencies»: {

    «eslint»: «^7.4.0»

  }

  2:32009  error  Strings must use singlequote                                               quotes

  3:23     error  Strings must use singlequote                                               quotes

  3:42     error  Missing semicolon                                                          semi

  3:43     error  Strings must use singlequote                                               quotes

  3:70     error  Strings must use singlequote                                               quotes

  3:166    error  Strings must use singlequote                                               quotes

  3:207    error  Strings must use singlequote                                               quotes

  3:280    error  Strings must use singlequote                                               quotes

  3:338    error  Missing semicolon                                                          semi

  3:460    error  Missing semicolon                                                          semi

  3:555    error  Missing semicolon                                                          semi

  4:22578  error  Missing semicolon                                                          semi

  4:22601  error  Missing semicolon                                                          semi

✖ 11436 problems (11436 errors, 0 warnings)

/my-project$ eslint . —ext .js —no-eslintrc —rule ‘indent: [«error», 4, { «SwitchCase»: 1 }]’

/my-project/path/to/file.js

   28:1  error  Expected indentation of 12 spaces but found 16  indent

   46:1  error  Expected indentation of 12 spaces but found 16  indent

  186:1  error  Expected indentation of 4 spaces but found 8    indent

  187:1  error  Expected indentation of 4 spaces but found 8    indent

  188:1  error  Expected indentation of 4 spaces but found 8    indent

  189:1  error  Expected indentation of 4 spaces but found 8    indent