Flake8 r503 python как исправить

you have set ignore = in your configuration — you should use extend-ignore =

W504 and W503 conflict with each other (and are both disabled by default) — by setting ignore you’ve re-enabled them. extend-ignore does not have this problem as it augments the default set of ignored codes

note that when working with black you’ll want to use black’s recommended settings: https://github.com/psf/black/blob/06ccb88bf2bd35a4dc5d591bb296b5b299d07323/docs/guides/using_black_with_other_tools.md#flake8

max-line-length = 88
extend-ignore = E203

disclaimer: I’m the current flake8 maintainer

• it also detects rule E501 and run the linter on the file doesn’t solve it

  – Antonio Santoro

  Jun 29, 2021 at 9:01

• 1

  then add that to extend-ignore too (though the max-line-length is supposed to cover that)

  – anthony sottile

  Jun 30, 2021 at 11:48

Add a comment
 | 

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Name

Email

Required, but never shown

def main():
    for a in range(10):                             # | 0 exception bad value
        try:                                        # | 1 ordinary value
            if a % 5 == 0:                          # | 2 good value
                raise ValueError('bad value')       # | 3 ordinary value
            elif a % 2 == 0:                        # | 4 good value
                print(a, 'good value')              # | 5 exception bad value
            else:                                   # | 6 good value
                print(a, 'ordinary value')          # | 7 ordinary value
        except ValueError as e:                     # | 8 good value
            print(a, 'exception', e)                # | 9 ordinary value


if __name__ == '__main__':
    main()

myfile.py:4:13: R506 unnecessary elif after raise statement.
            if a % 5 == 0:

def main():                                         # | 0 exception bad value
    for a in range(10):                             # | 0 good value
        if a % 5 == 0:                              # | 1 ordinary value
            print(a, 'exception', 'bad value')      # | 2 good value
        if a % 2 == 0:                              # | 3 ordinary value
            print(a, 'good value')                  # | 4 good value
        else:                                       # | 5 exception bad value
            print(a, 'ordinary value')              # | 5 ordinary value
                                                    # | 6 good value
                                                    # | 7 ordinary value
if __name__ == '__main__':                          # | 8 good value
    main()                                          # | 9 ordinary value

def get_service_for_object(
    obj: events.EventWrapper | markets.MarketWrapper,
) -> events.Service | markets.Service:
    """
    Args:
        obj: The parsed ZF push object.

    Returns:
        Relevant service object for the type.
    """
    match obj:
        case events.EventWrapper():
            return events.Service(obj)
        case markets.MarketWrapper():
            return markets.Service(obj)
        case _:  # pragma: no cover
            raise RuntimeError("Unexpected object type.")

def test_2(bar):
    if bar == 3:
        baz = 1
    elif bar == 4:
        raise Exception()
    else:
        baz = 2
    return baz

$ flake8 test.py 
test.py:4:5: R506 unnecessary else after raise statement.

def main():
    for a in range(10):                     # | 0 div 4
        if a % 4 == 0:                      # | 1 div nothing
            print(a, 'div', 4)              # | 2 div 2
        elif a % 3 == 0:                    # | 3 div 3
            print(a, 'div', 3)              # | 4 div 4
            continue                        # | 5 div nothing
        elif a % 2 == 0:                    # | 6 div 3
            print(a, 'div', 2)              # | 7 div nothing
        else:                               # | 8 div 4
            print(a, 'div', 'nothing')      # | 9 div 3
    return 0



if __name__ == '__main__':
    main()

myfile.py:5:9: R507 unnecessary elif after continue statement.
        elif a % 3 == 0:
        ^

def main():                                 # | 0 div 4
    for a in range(10):                     # | 0 div 2
        if a % 4 == 0:                      # | 1 div nothing
            print(a, 'div', 4)              # | 2 div 2
        elif a % 3 == 0:                    # | 3 div 3
            print(a, 'div', 3)              # | 4 div 4
            continue                        # | 4 div 2
        if a % 2 == 0:                      # | 5 div nothing
            print(a, 'div', 2)              # | 6 div 3
        else:                               # | 7 div nothing
            print(a, 'div', 'nothing')      # | 8 div 4
    return 0                                # | 8 div 2
                                            # | 9 div 3

if __name__ == '__main__':
    main()

def get_name(name):
    if name == 'foo':
        return 'foo'
    elif name == 'bar':
        return 'bar'

    return 'baz'

a.py:2:5: R505 unnecessary elif after return statement.

repos:
  ...
  - repo: https://github.com/PyCQA/flake8
    rev: 5.0.4
    hooks:
      - id: flake8
        additional_dependencies:
          - flake8-return
          ...
        args: [--config, setup.cfg]

@pytest.fixture()
def example_mock_fails_linting(mocker):
    mock = mocker.MagicMock()
    mocker.patch("path.to.mocked.method.that.returns.an.object").return_value = mock
    return mock # R504 triggers for this line


@pytest.fixture()
def example_mock_lints_clean(mocker):
    example = mocker.patch("path.to.mocked.method.that.returns.an.object")
    example.return_value = mocker.MagicMock()
    return example.return_value # R504 doesn't trigger for this line

ret = fn()
if bad:
    raise BadThingHappenedError(msg)
elif okish:
    return fixit(ret)
else:
    return ret

ret = fn()
if bad:
    raise BadThingHappenedError(msg)
if okish:
    return fixit(ret)
return ret

def no_exception_loop():
    success = False
    for _ in range(10):
        try:
            success = True
        except Exception:
            print("exception")  # noqa: T201
    return success


def no_exception():
    success = False
    try:
        success = True
    except Exception:
        print("exception")  # noqa: T201
    return success


def exception():
    success = True
    try:
        print("raising")  # noqa: T201
        raise Exception
    except Exception:
        success = False
    return success

$ poetry run flake8 --show-source debug.py
Unable to find qualified name for module: debug.py
debug.py:8:12: R504 unecessary variable assignement before return statement.
    return success
           ^
debug.py:17:12: R504 unecessary variable assignement before return statement.
    return success
           ^
debug.py:27:12: R504 unecessary variable assignement before return statement.
    return success
           ^

def close(self):
    any_failed = False
    for task in self.tasks:
        try:
            task()
        except BaseException:
            any_failed = True
            report(traceback.format_exc())
    return any_failed  # R504 you shouldn't assign value to variable if it will be use only as return value

    formatted = _USER_AGENT_FORMATTER.format(format_string, **values)
    # clean up after any blank components
    formatted = formatted.replace('()', '').replace('  ', ' ').strip()
    return formatted  # <<< wrongly indicated as R504 issue

def user_agent_username(username=None):

    if not username:
        return ''

    username = username.replace(' ', '_')  # Avoid spaces or %20.
    try:
        username.encode('ascii')  # just test, but not actually use it
    except UnicodeEncodeError:
        username = quote(username.encode('utf-8'))
    else:
        # % is legal in the default $wgLegalTitleChars
        # This is so that ops know the real pywikibot will not
        # allow a useragent in the username to allow through a hand-coded
        # percent-encoded value.
        if '%' in username:
            username = quote(username)
    return username  # <<< wrongly indicated as R504 issue

2020-11-27 12:43:25,280 UTC - ERROR - pyls.plugins.flake8_lint - Error while running flake8 'Traceback (most recent call last):
  File "some_code/.venv/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "some_code/.venv/lib/python3.8/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "some_code/.venv/lib/python3.8/site-packages/flake8/main/application.py", line 363, in run
    self._run(argv)
  File "some_code/.venv/lib/python3.8/site-packages/flake8/main/application.py", line 351, in _run
    self.run_checks()
  File "some_code/.venv/lib/python3.8/site-packages/flake8/main/application.py", line 264, in run_checks
    self.file_checker_manager.run()
  File "some_code/.venv/lib/python3.8/site-packages/flake8/checker.py", line 323, in run
    self.run_serial()
  File "some_code/.venv/lib/python3.8/site-packages/flake8/checker.py", line 307, in run_serial
    checker.run_checks()
  File "some_code/.venv/lib/python3.8/site-packages/flake8/checker.py", line 589, in run_checks
    self.run_ast_checks()
  File "some_code/.venv/lib/python3.8/site-packages/flake8/checker.py", line 494, in run_ast_checks
    for (line_number, offset, text, _) in runner:
  File "some_code/.venv/lib/python3.8/site-packages/flake8_plugin_utils/plugin.py", line 75, in run
    self._load_file()
  File "some_code/.venv/lib/python3.8/site-packages/flake8_plugin_utils/plugin.py", line 87, in _load_file
    with open(self._filename, 'rb') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'stdin'
'

def test():
    a = 1
    match a:  # <---- D400 First line should end with a period
      case 0:
        return False
      case 1:
        return True
      case _*:
        return False

def myfunc(x):
    if x == 5:
        return None
    assert False

def myfunc(x):
    if x == 5:
        return None
    raise NotImplementedError()

from functools import wraps

def rootonly(func):
    @wraps(func)
    def check_parallel_rank(*args, **kwargs):
        global topcomm_parallel_rank
        if topcomm_parallel_rank > 0:
            return
        return func(*args, **kwargs)
    return check_parallel_rank

from typing import Optional
from types import FunctionType
# ...
    def check_parallel_rank(*args, **kwargs) -> Optional[FunctionType]:
# ...

def doit():
    test = 1
    i = 4

    while i := i - 1:
        test = test + 1

    return test

class Node:
    def __init__(self, v, parent=None):
        self.v = v
        self.parent = parent
        self.child = Node(v - 1, parent=self) if v else None

    def __str__(self):
        name = f"Node<{self.v}>"
        node = self

        while node := node.parent:
            name = f"Node<{node.v}>.{name}"

        return name

    def tail(self):
        node = self
        while node.child:
            node = node.child
        return node

print(Node(5).tail())

$ flake8 test.py 
test.py:5:12: R504 you shouldn`t assign value to variable if it will be use only as return value
$ cat test.py
def foo(bar):
    value = []
    if bar:
        value = value[:1]
    return value

async def function():
    async with thing as foo:
        return foo.bar

def some_method(parameter):
   if some_test:
     return some_value
   elif another_test:
     return another_value
   else:
     assert False, "parameter was not some_value nor another_value"